Copilot commented on code in PR #2285: URL: https://github.com/apache/sedona/pull/2285#discussion_r2292736674
########## spark/common/src/test/scala/org/apache/sedona/sql/geography/FunctionsTest.scala: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.sedona.sql.geography + +import org.apache.sedona.common.S2Geography.Geography +import org.apache.sedona.common.geography.{Constructors, Functions} +import org.apache.sedona.sql.TestBaseScala +import org.junit.Assert.assertEquals +import org.locationtech.jts.geom.{Geometry, PrecisionModel} +import org.locationtech.jts.io.WKTWriter Review Comment: The imports Geometry and WKTWriter are not used in this test file. Consider removing unused imports. ```suggestion import org.locationtech.jts.geom.PrecisionModel ``` ########## common/src/test/java/org/apache/sedona/common/Geography/FucntionTest.java: ########## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.sedona.common.Geography; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; + +import com.google.common.geometry.S2LatLng; +import com.google.common.geometry.S2LatLngRect; +import com.google.common.geometry.S2Loop; +import com.google.common.geometry.S2Point; +import org.apache.sedona.common.S2Geography.Geography; +import org.apache.sedona.common.S2Geography.PolygonGeography; +import org.apache.sedona.common.geography.Constructors; +import org.apache.sedona.common.geography.Functions; +import org.junit.Test; +import org.locationtech.jts.io.ParseException; + +public class FucntionTest { Review Comment: Class name contains a typo: 'FucntionTest' should be 'FunctionTest'. ```suggestion public class FunctionTest { ``` ########## spark/common/src/test/scala/org/apache/sedona/sql/geography/FunctionsTest.scala: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.sedona.sql.geography + +import org.apache.sedona.common.S2Geography.Geography +import org.apache.sedona.common.geography.{Constructors, Functions} +import org.apache.sedona.sql.TestBaseScala +import org.junit.Assert.assertEquals +import org.locationtech.jts.geom.{Geometry, PrecisionModel} +import org.locationtech.jts.io.WKTWriter Review Comment: The WKTWriter import is not used in this test file. Consider removing unused imports. ```suggestion ``` ########## spark/common/src/test/scala/org/apache/sedona/sql/geography/FunctionsTest.scala: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.sedona.sql.geography + +import org.apache.sedona.common.S2Geography.Geography +import org.apache.sedona.common.geography.{Constructors, Functions} +import org.apache.sedona.sql.TestBaseScala +import org.junit.Assert.assertEquals +import org.locationtech.jts.geom.{Geometry, PrecisionModel} +import org.locationtech.jts.io.WKTWriter + +class FunctionsTest extends TestBaseScala { + + import sparkSession.implicits._ + val precisionModel: PrecisionModel = new PrecisionModel(PrecisionModel.FIXED); Review Comment: The precisionModel variable is declared but never used in any of the test methods. Consider removing it or using it in the tests if needed. ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
