Kontinuation commented on code in PR #2285:
URL: https://github.com/apache/sedona/pull/2285#discussion_r2286852539


##########
docs/api/sql/geography/Function.md:
##########
@@ -16,3 +16,26 @@
  specific language governing permissions and limitations
  under the License.
  -->
+
+## ST_Envelope
+
+Introduction: This function returns the bounding box (envelope) of A. If the 
envelope crosses the antimeridian (the 180° longitude line), you can set the 
split parameter to true. This will return a Geography object containing two 
separate Polygon objects, split along that line.

Review Comment:
   We should emphasize that the bounding box is in **cylindrical** topology 
rather than a spherical one.
   
   The unclear semantics of this function is probably the reason why 
ST_ENVELOPE is depcrecated by snowflake: 
https://docs.snowflake.com/en/sql-reference/functions/st_envelope



##########
docs/api/sql/geography/Function.md:
##########
@@ -16,3 +16,26 @@
  specific language governing permissions and limitations
  under the License.
  -->
+
+## ST_Envelope
+
+Introduction: This function returns the bounding box (envelope) of A. If the 
envelope crosses the antimeridian (the 180° longitude line), you can set the 
split parameter to true. This will return a Geography object containing two 
separate Polygon objects, split along that line.
+
+Format:
+
+`ST_Envelope (A: Geography, splitAtAntiMeridian: Boolean)`
+
+Since: `v1.8.0`
+
+SQL Example
+
+```sql
+SELECT ST_Envelope(ST_GeogFromWKT('MULTIPOLYGON (((177.285 -18.28799, 180 
-18.28799, 180 -16.02088, 177.285 -16.02088, 177.285 -18.28799)),((-180 
-18.28799, -179.7933 -18.28799, -179.7933 -16.02088, -180 -16.02088, -180 
-18.28799)))
+', false))
+```

Review Comment:
   This example SQL is incorrect. `false` should be passed as into ST_Envelope 
instead of ST_GeogFromWKT.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to