paleolimbot commented on code in PR #1778:
URL: https://github.com/apache/sedona/pull/1778#discussion_r1938183783
##########
spark/common/src/main/java/org/apache/sedona/core/spatialRDD/SpatialRDD.java:
##########
@@ -159,6 +159,32 @@ public boolean spatialPartitioning(GridType gridType)
throws Exception {
return true;
}
+ public boolean spatialParitioningWithoutDuplicates(GridType gridType) throws
Exception {
Review Comment:
I do tend to have a preference towards methods (but also happy to change
this to the prevailing opinion!). I know most Java IDEs let you toggle inlays
that make this mute, but my theory was that
`spatialParitioningWithoutDuplicates(GridType.KDBTREE)` is slightly more
informative to read than `spatialPartitioning(GridType.KDBTREE, false)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
