paleolimbot commented on code in PR #1778:
URL: https://github.com/apache/sedona/pull/1778#discussion_r1936241937
##########
spark/common/src/main/java/org/apache/sedona/core/spatialRDD/SpatialRDD.java:
##########
@@ -278,7 +304,7 @@ public void spatialPartitioning(SpatialPartitioner
partitioner) {
/** @deprecated Use spatialPartitioning(SpatialPartitioner partitioner) */
public boolean spatialPartitioning(final List<Envelope> otherGrids) throws
Exception {
- this.partitioner = new FlatGridPartitioner(otherGrids);
+ this.partitioner = new IndexedGridPartitioner(otherGrids);
Review Comment:
I think this probably is a better default (log complexity vs. linear
complexity for placement). It's important to support this one for the
partitioning use case (enables composability between the "generate my grids"
and "partition my data" steps).
##########
spark/common/src/main/java/org/apache/sedona/core/spatialPartitioning/IndexedGridPartitioner.java:
##########
@@ -48,7 +48,7 @@ public IndexedGridPartitioner(
}
public IndexedGridPartitioner(GridType gridType, List<Envelope> grids) {
- this(gridType, grids, false);
+ this(gridType, grids, true);
Review Comment:
This aligns the default between the `IndexedGridPartitioner` and the
`FlatGridPartitioner`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
