adutra commented on code in PR #3960:
URL: https://github.com/apache/polaris/pull/3960#discussion_r2931771436
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DefaultDataSourceResolver.java:
##########
@@ -16,42 +16,38 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.polaris.quarkus.common.config.jdbc;
+package org.apache.polaris.persistence.relational.jdbc;
-import io.quarkus.arc.DefaultBean;
+import io.smallrye.common.annotation.Identifier;
import jakarta.enterprise.context.ApplicationScoped;
+import jakarta.enterprise.inject.Any;
import jakarta.enterprise.inject.Instance;
import jakarta.inject.Inject;
import javax.sql.DataSource;
import org.apache.polaris.core.context.RealmContext;
-import org.apache.polaris.persistence.relational.jdbc.DataSourceResolver;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
- * Default implementation of {@link DataSourceResolver} that routes all realms
and store types to a
- * single default {@link DataSource}. This implementation acts as a fallback;
downstream users can
- * provide their own {@link DataSourceResolver} bean to implement custom
routing logic.
+ * Default implementation of {@link DataSourceResolver} that routes all realms
to a single default
+ * {@link DataSource}.
*/
@ApplicationScoped
-@DefaultBean
+@Identifier("polaris")
Review Comment:
Let's use `@Identifier("default")` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
