Subham-KRLX commented on PR #3960:
URL: https://github.com/apache/polaris/pull/3960#issuecomment-4054548664
@adutra @dimas-b @flyingImer Thanks for the detailed feedback! I've pushed
an update that addresses all comments. StoreType has been removed entirely
since JdbcBasePersistenceImpl currently handles both MetaStore and
MetricsPersistence — we can reintroduce it once workloads are actually
isolated. @DefaultBean has been replaced with @Identifier("polaris") and a
producer method in ServiceProducers, following the standard Polaris pattern for
pluggable components. DefaultDataSourceResolver now lives in
polaris-relational-jdbc alongside its interface, and
JdbcMetaStoreManagerFactory injects DataSourceResolver directly. I kept
Instance<DataSource> (with @Any) in the default resolver to avoid
InactiveBeanException in non-JDBC profiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
