rok commented on code in PR #603: URL: https://github.com/apache/parquet-format/pull/603#discussion_r3844968093
########## LogicalTypes.md: ########## @@ -727,51 +724,60 @@ object-store eTag for the whole file referenced by `uri`. ##### inline The referenced bytes stored inline in the value. If `inline` is set, it supplies the -bytes and any locator fields (`uri`, `offset`, `size`) that are set are provenance -only. +bytes and any locator fields (`uri`, `offset`, `size`) that are set are provenance only. +Both representations must denote the same bytes, so a reader may resolve the value from +either and obtain the same result; reading `inline` requires no external access and is +the cheaper path. A locator set alongside `inline` records where those bytes came from, Review Comment: > inline requires no external access and is the cheaper path. Is the cheaper path comment required here? I don't disagree with it, it just doesn't feel necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
