iemejia commented on code in PR #573:
URL: https://github.com/apache/parquet-format/pull/573#discussion_r3345348679
##########
src/main/thrift/parquet.thrift:
##########
@@ -431,7 +431,7 @@ enum EdgeInterpolationAlgorithm {
/**
* Embedded Geometry logical type annotation
*
- * Geospatial features in the Well-Known Binary (WKB) format and edges
interpolation
+ * Geospatial features in the Well-Known Binary (WKB) format and edge
interpolation
Review Comment:
Good point, changed to ```edges``` interpolation with backticks.
##########
src/main/thrift/parquet.thrift:
##########
@@ -600,8 +600,9 @@ enum Encoding {
*/
RLE = 3;
- /** Bit packed encoding. This can only be used if the data has a known max
+ /** Deprecated: Bit packed encoding. This can only be used if the data has
a known max
Review Comment:
Agreed, standardized all label-style occurrences to `DEPRECATED:`
(uppercase), inspired by the RFC convention for keywords. Inline prose uses
(e.g. "this field is now deprecated") are left lowercase as normal English.
##########
src/main/thrift/parquet.thrift:
##########
@@ -583,15 +583,15 @@ enum Encoding {
PLAIN = 0;
/** Group VarInt encoding for INT32/INT64.
- * This encoding is deprecated. It was never used
+ * This encoding is deprecated. It was never used.
*/
// GROUP_VAR_INT = 1;
/**
* Deprecated: Dictionary encoding. The values in the dictionary are encoded
in the
* plain type.
* in a data page use RLE_DICTIONARY instead.
- * in a Dictionary page use PLAIN instead
+ * in a Dictionary page use PLAIN instead.
Review Comment:
Done. Changed both sentences to start with "For a ..." and capitalized: `For
a data page use RLE_DICTIONARY instead.` / `For a Dictionary page use PLAIN
instead.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
