etseidl commented on code in PR #573:
URL: https://github.com/apache/parquet-format/pull/573#discussion_r3344099311
##########
src/main/thrift/parquet.thrift:
##########
@@ -583,15 +583,15 @@ enum Encoding {
PLAIN = 0;
/** Group VarInt encoding for INT32/INT64.
- * This encoding is deprecated. It was never used
+ * This encoding is deprecated. It was never used.
*/
// GROUP_VAR_INT = 1;
/**
* Deprecated: Dictionary encoding. The values in the dictionary are encoded
in the
* plain type.
* in a data page use RLE_DICTIONARY instead.
- * in a Dictionary page use PLAIN instead
+ * in a Dictionary page use PLAIN instead.
Review Comment:
```suggestion
* In a Dictionary page use PLAIN instead.
```
If we're adding punctuation, then shouldn't we also capitalize? And now that
I think of it, should it be "For a..." rather than "In a..."
##########
src/main/thrift/parquet.thrift:
##########
@@ -600,8 +600,9 @@ enum Encoding {
*/
RLE = 3;
- /** Bit packed encoding. This can only be used if the data has a known max
+ /** Deprecated: Bit packed encoding. This can only be used if the data has
a known max
Review Comment:
We're pretty inconsistent here. Sometimes "DEPRECATED:", others
"Deprecated:". Perhaps we should standardize?
##########
src/main/thrift/parquet.thrift:
##########
@@ -431,7 +431,7 @@ enum EdgeInterpolationAlgorithm {
/**
* Embedded Geometry logical type annotation
*
- * Geospatial features in the Well-Known Binary (WKB) format and edges
interpolation
+ * Geospatial features in the Well-Known Binary (WKB) format and edge
interpolation
Review Comment:
I think "edges" is the common usage in GeoParquet. Maybe this should be in
backticks (`edges`) here and elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
