ArnavBalyan commented on code in PR #3271:
URL: https://github.com/apache/parquet-java/pull/3271#discussion_r2310922780
##########
parquet-column/src/main/java/org/apache/parquet/io/ValidatingRecordConsumer.java:
##########
@@ -46,7 +48,11 @@
public class ValidatingRecordConsumer extends RecordConsumer {
private static final Logger LOG =
LoggerFactory.getLogger(ValidatingRecordConsumer.class);
+ private static final int UINT_8_MAX_VALUE = 255;
+ private static final int UINT_16_MAX_VALUE = 65535;
+
private final RecordConsumer delegate;
+ private final boolean strictUnsignedIntegerValidation;
Review Comment:
Unfortunately there are several test breaking and existing code built with
the assumption of no validation. Since we put the changes directly within
`ValidatingRecordConsumer` it causes existing behaviour to break. I added this
with a feature flag so new users can start using the validation. I'll
investigate as a followup if we can cleanup/fix existing code thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
