parthchandra commented on code in PR #3271:
URL: https://github.com/apache/parquet-java/pull/3271#discussion_r2310805972
##########
parquet-column/src/main/java/org/apache/parquet/io/ValidatingRecordConsumer.java:
##########
@@ -46,7 +48,11 @@
public class ValidatingRecordConsumer extends RecordConsumer {
private static final Logger LOG =
LoggerFactory.getLogger(ValidatingRecordConsumer.class);
+ private static final int UINT_8_MAX_VALUE = 255;
+ private static final int UINT_16_MAX_VALUE = 65535;
+
private final RecordConsumer delegate;
+ private final boolean strictUnsignedIntegerValidation;
Review Comment:
+1
##########
parquet-column/src/main/java/org/apache/parquet/io/ValidatingRecordConsumer.java:
##########
@@ -46,7 +48,11 @@
public class ValidatingRecordConsumer extends RecordConsumer {
private static final Logger LOG =
LoggerFactory.getLogger(ValidatingRecordConsumer.class);
+ private static final int UINT_8_MAX_VALUE = 255;
+ private static final int UINT_16_MAX_VALUE = 65535;
Review Comment:
UINT_8, UINT_16, and UINT_32 annotate an int32 value, UINT_64 annotatyes a
i64 value. For UINT_8, and UINT16 valid values are in the range [0,
UINT_8_MAX_VALUE] and [0, UINT_16_MAX_VALUE] respectively. For UINT_32 and
UINT_64, all non negative values are valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
