RussellSpitzer commented on code in PR #496:
URL: https://github.com/apache/parquet-format/pull/496#discussion_r2167123991
##########
src/main/thrift/parquet.thrift:
##########
@@ -461,6 +461,29 @@ struct GeographyType {
2: optional EdgeInterpolationAlgorithm algorithm;
}
+/**
+ * Year-Month Interval logical type annotation
+ *
+ * The data is stored as an 4 byte signed integer which represents the number
+ * of months associated with the time interval. The value can be negative to
+ * indicate a backward duration.
+ *
+ * Allowed for physical type: INT32
+ */
+struct IntervalYearMonthType {
+}
+
+/**
+ * Month-Day Interval logical type annotation
+ *
+ * The data is stored as a 16-byte signed value, which represents the number
Review Comment:
One thing i'm a little worried about with the Arrow definition for
MonthDayNano is the handling of bounds. According to the arrow spec the Nano
and Day portions are allowed to vary in signs. Wouldn't this make calculations
of min-max values a bit more confusing? I think if we did go that route, and
i'm not sure we should, but I think we would have to add a few other
limitations which would diverge a bit there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
