RussellSpitzer commented on code in PR #496:
URL: https://github.com/apache/parquet-format/pull/496#discussion_r2167115871
##########
src/main/thrift/parquet.thrift:
##########
@@ -461,6 +461,29 @@ struct GeographyType {
2: optional EdgeInterpolationAlgorithm algorithm;
}
+/**
+ * Year-Month Interval logical type annotation
+ *
+ * The data is stored as an 4 byte signed integer which represents the number
+ * of months associated with the time interval. The value can be negative to
+ * indicate a backward duration.
+ *
+ * Allowed for physical type: INT32
+ */
+struct IntervalYearMonthType {
+}
+
+/**
+ * Month-Day Interval logical type annotation
+ *
+ * The data is stored as a 16-byte signed value, which represents the number
+ * of nanoseconds. The value can be negative to indicate a backward duration.
+ *
+ * Allowed for physical type: FIXED_LEN_BYTE_ARRAY
+ */
+struct IntervalMonthDayType {
Review Comment:
My thoughts here were similar, generally we want to add different precisions
is because we want to cover different ranges of possible values, but if our
underlying type can support the full range we expect of other precisions it
probably isn't important.
I think this is basically the rational behind some of the other interval
types like in MonthDayNanos (assuming you treat days not as calendar days - not
in spec but theoretically you could have done that)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
