dominicso commented on PR #3206: URL: https://github.com/apache/parquet-java/pull/3206#issuecomment-2860367726
Rebased and changed to use AtomicBoolean. > I think this needs a test, even just for local file output, calling close() twice, ideally on separate threads. @steveloughran If a test is added to use local file output, wouldn't it use `LocalPositionOutputStream` instead of `HadoopPositionOutputStream`? Perhaps a unit test should be added just to call `HadoopPositionOutputStream.close(`)? Looking at `LocalPositionOutputStream.close()`, it looks like it also needs similar changes to make repeat calls to its close safe. Let me know if this should be done as part of this PR as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
