steveloughran commented on PR #3206:
URL: https://github.com/apache/parquet-java/pull/3206#issuecomment-2844704393
just looked at flush() implementations
s3a: tells you off
```
@Override
public synchronized void flush() throws IOException {
try {
checkOpen();
} catch (ClosedIOException e) {
LOG.warn("Stream closed: {}", e.getMessage());
return;
}
S3ADataBlocks.DataBlock dataBlock = getActiveBlock();
if (dataBlock != null) {
dataBlock.flush();
}
}
```
abfs: probably raises `IllegalStateException`
file: whatever `java.io.FileOutputStream` does
hdfs: does seem to queue stuff
overall then: dangerous to call flush() on a closed stream. Wrapping it is
safer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
