wgtmac commented on code in PR #494:
URL: https://github.com/apache/parquet-format/pull/494#discussion_r2057297000
##########
Geospatial.md:
##########
@@ -162,3 +192,18 @@ The axis order of the coordinates in WKB and bounding box
stored in Parquet
follows the de facto standard for axis order in WKB and is therefore always
(x, y) where x is easting or longitude and y is northing or latitude. This
ordering explicitly overrides the axis order as specified in the CRS.
+
+# Invalid geospatial values
+
+An invalid geospatial value refers to any of the following cases:
+
+* `null`: A null value in Parquet.
+* A non-`null` value that are encoded in a valid WKB or bounding box format
Review Comment:
Perhaps it is better to distinguish invalid bbox and invalid WKB value?
##########
Geospatial.md:
##########
@@ -94,6 +94,36 @@ Bounding box is defined as the thrift struct below in the
representation of
min/max value pair of coordinates from each axis. Note that X and Y Values are
always present. Z and M are omitted for 2D geospatial instances.
+Writers should follow the guidelines below when calculating bounding boxes in
+the presence of [invalid geospatial values](#invalid-geospatial-values).
+
+* X and Y: Skip any invalid X or Y value and continue processing the remaining
X or Y
+ values. Do not produce a bounding box if all X or all Y values are invalid.
Review Comment:
```suggestion
* X and Y: Skip any invalid X or Y value and continue processing the
remaining X or Y
values. Do not produce a bounding box if all X and/or all Y values are
invalid (even
if there are valid Z and/or M values).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
