aihuaxu commented on code in PR #3072:
URL: https://github.com/apache/parquet-java/pull/3072#discussion_r2038654228
##########
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java:
##########
@@ -1183,6 +1183,8 @@ LogicalTypeAnnotation
getLogicalTypeAnnotation(LogicalType type) {
return LogicalTypeAnnotation.uuidType();
case FLOAT16:
return LogicalTypeAnnotation.float16Type();
+ case VARIANT:
+ return LogicalTypeAnnotation.variantType();
Review Comment:
@rdblue, @emkornfield I have some basic questions on this
specification_version. We already the version (that should be this
specification_version?) in the variant header.
I can see that we define a constant of `VARIANT_SPECIFICATION_VERSION` and
the writer will write that into the header. Then the reader should be able to
fetch the version and parse the variant if it's supported.
Variant logical type may not be associated with a version. Let me know if I
misunderstand anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
