rdblue commented on code in PR #3072:
URL: https://github.com/apache/parquet-java/pull/3072#discussion_r2023624420
##########
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java:
##########
@@ -524,6 +525,11 @@ public Optional<LogicalType>
visit(LogicalTypeAnnotation.UnknownLogicalTypeAnnot
public Optional<LogicalType>
visit(LogicalTypeAnnotation.IntervalLogicalTypeAnnotation intervalLogicalType) {
return of(LogicalType.UNKNOWN(new NullType()));
}
+
+ @Override
+ public Optional<LogicalType>
visit(LogicalTypeAnnotation.VariantLogicalTypeAnnotation variantLogicalType) {
+ return of(LogicalTypes.VARIANT());
Review Comment:
The other cases create new instances of the logical type, but I agree with
using the `LogicalTypes` constant. This just doesn't need to be a method call.
It would also be nice to follow up with a PR that converts all of these to the
correct constant rather than creating new instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
