rdblue commented on code in PR #240:
URL: https://github.com/apache/parquet-format/pull/240#discussion_r1927549713
##########
LogicalTypes.md:
##########
@@ -599,6 +599,45 @@ optional group variant_shredded (VARIANT) {
}
```
+### GEOMETRY
+
+`GEOMETRY` is used for geometry features in the Well-Known Binary (WKB) format
+with linear/planar edges interpolation. It must annotate a `BYTE_ARRAY`
+primitive type. See [Geospatial.md](Geospatial.md) for more detail.
+
+The type has two type parameters:
+- `crs`: An optional string value for CRS. If unset, the CRS defaults to
+ "OGC:CRS84", which means that the geometries must be stored in longitude,
+ latitude based on the WGS84 datum.
+- `crs_encoding`: An optional enum value to describes the encoding used by the
Review Comment:
I'm strongly against the current type parameters. The CRS should not be
embedded, it should be referenced like the spec in Iceberg. There's no need to
duplicate these, require support for specific formats, or make type annotations
huge. A CRS reference ID is cleaner, along with a way to store the CRS
definition in file metadata if that's desired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For additional commands, e-mail: issues-h...@parquet.apache.org
