paleolimbot commented on code in PR #240:
URL: https://github.com/apache/parquet-format/pull/240#discussion_r1923067914
##########
LogicalTypes.md:
##########
@@ -599,6 +599,45 @@ optional group variant_shredded (VARIANT) {
}
```
+### GEOMETRY
+
+`GEOMETRY` is used for geometry features in the Well-Known Binary (WKB) format
+with linear/planar edges interpolation. It must annotate a `BYTE_ARRAY`
+primitive type. See [Geospatial.md](Geospatial.md) for more detail.
+
+The type has two type parameters:
+- `crs`: An optional string value for CRS. If unset, the CRS defaults to
+ "OGC:CRS84", which means that the geometries must be stored in longitude,
+ latitude based on the WGS84 datum.
+- `crs_encoding`: An optional enum value to describes the encoding used by the
Review Comment:
I am happy with either (they encode equivalent information); however, I
think separating them specifically for Parquet is a little nicer. I do like
that there is a clear way for a writer to write an arbitrary string if it
doesn't have the means to validate that it received PROJJSON (or doesn't have
the ability to generate it). I also don't feel strongly about that 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For additional commands, e-mail: issues-h...@parquet.apache.org
