adoroszlai commented on code in PR #6402:
URL: https://github.com/apache/ozone/pull/6402#discussion_r1533547845
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -563,6 +563,10 @@ public final class OzoneConfigKeys {
"ozone.om.keyname.character.check.enabled";
public static final boolean OZONE_OM_KEYNAME_CHARACTER_CHECK_ENABLED_DEFAULT
=
false;
+ public static final String HDDS_DN_CHUNK_DATA_CHECK_ENABLED_KEY =
+ "hdds.datanode.chunk.data.validation.check";
+ public static final boolean HDDS_DN_CHUNK_DATA_CHECK_ENABLED_DEFAULT =
+ false;
Review Comment:
If this is an existing property from `DatanodeConfiguration`, then it
shouldn't be added to `ozone-default.xml`, nor should it have a constant in
`OzoneConfigKeys`.
The test can set it similar to:
https://github.com/apache/ozone/blob/d70d247a494a69cad28e96d003b25ae4856b8641/hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/TestBlockDeletingService.java#L662
https://github.com/apache/ozone/blob/d70d247a494a69cad28e96d003b25ae4856b8641/hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/TestBlockDeletingService.java#L665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
