Cyrill opened a new pull request, #6402:
URL: https://github.com/apache/ozone/pull/6402

   ## What changes were proposed in this pull request?
   HDDS-10547. Fix the buffer for the datanode checksum calculation
   
   Datanode chunk checksum validation was broken. 
   computeChecksum code and chunkWrite code shared the same byte buffer, hence 
the first one to read from the buffer succeeds and the second attempt to read 
fails as the buffer position is at the end.
   
   Apparently there are no tests to check that. I returned back the previous 
code to make it work. 
   There are three places where `validateChunkChecksumData` is called. I added 
a unit test to check all three. Also I had to change `handlePutSmallFile` 
method as it didn't work correctly even with the checksum buffer fix.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-10547
   
   ## How was this patch tested?
   
   Unit tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to