whbing commented on code in PR #6319:
URL: https://github.com/apache/ozone/pull/6319#discussion_r1510838766
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneAclUtil.java:
##########
@@ -91,23 +94,22 @@ public static List<OzoneAcl> filterAclList(String
identityName,
private static boolean checkAccessInAcl(OzoneAcl a, UserGroupInformation ugi,
ACLType aclToCheck) {
- BitSet rights = a.getAclBitSet();
switch (a.getType()) {
case USER:
if (a.getName().equals(ugi.getShortUserName())) {
- return checkIfAclBitIsSet(aclToCheck, rights);
+ return a.checkAccess(aclToCheck);
Review Comment:
NIT: `checkIfAclBitIsSet` method can be removed as it not in used now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
