ivandika3 commented on code in PR #6319:
URL: https://github.com/apache/ozone/pull/6319#discussion_r1510557268
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneAclUtil.java:
##########
@@ -160,18 +162,22 @@ public static boolean
checkIfAclBitIsSet(IAccessAuthorizer.ACLType acl,
* OzoneUtils.addAcl().
* @param acls
* @param parentAcls
+ * @param scope
Review Comment:
Thanks for the logic simplificaation. Could you help update the Javadoc for
`inheritDefaultAcls`?
> Helper function to inherit default ACL as access ACL for child object
Is outdated since the inherited ACLs can be of DEFAULT scope (for directory
ACLs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
