hemantk-12 commented on code in PR #6012:
URL: https://github.com/apache/ozone/pull/6012#discussion_r1467251825
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java:
##########
@@ -174,8 +174,11 @@ protected KeyArgs resolveBucketAndCheckOpenKeyAcls(KeyArgs
keyArgs,
return resolvedArgs;
}
- protected void validateKeyName(OzoneManager ozoneManager, String keyName)
- throws OMException {
+ protected void validateKeyName(OzoneManager ozoneManager, KeyArgs keyArgs,
+ String keyName) throws OMException {
+ if (keyArgs != null && keyArgs.getKeyName() != null) {
Review Comment:
I think it was a miss or bug that
`OmUtils.verifyKeyNameWithSnapshotReservedWord(renameKeyRequest.getToKeyName());`
check was not added for rename.
This helper function should be:
```
protected void validateKeyName(OzoneManager ozoneManager, String keyName)
throws OMException {
OmUtils.verifyKeyNameWithSnapshotReservedWord(keyName);
final boolean checkKeyNameEnabled = ozoneManager.getConfiguration()
.getBoolean(OMConfigKeys.OZONE_OM_KEYNAME_CHARACTER_CHECK_ENABLED_KEY,
OMConfigKeys.OZONE_OM_KEYNAME_CHARACTER_CHECK_ENABLED_DEFAULT);
if (checkKeyNameEnabled) {
OmUtils.validateKeyName(keyName);
}
}
```
In the end, we have to make sure the final key and dir name should be valid.
For create request, final keyName is `keyArgs.getKeyName()` and for rename it
is `renameKeyRequest.getToKeyName()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
