jianghuazhu commented on code in PR #6012:
URL: https://github.com/apache/ozone/pull/6012#discussion_r1467186739
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java:
##########
@@ -174,8 +174,11 @@ protected KeyArgs resolveBucketAndCheckOpenKeyAcls(KeyArgs
keyArgs,
return resolvedArgs;
}
- protected void validateKeyName(OzoneManager ozoneManager, String keyName)
- throws OMException {
+ protected void validateKeyName(OzoneManager ozoneManager, KeyArgs keyArgs,
+ String keyName) throws OMException {
+ if (keyArgs != null && keyArgs.getKeyName() != null) {
Review Comment:
If that's the case, it seems like there's still something to discuss.
For OMKeyRenameRequest:
`
OmUtils.verifyKeyNameWithSnapshotReservedWord(renameKeyRequest.getToKeyName());
`
And for other types:
`
OmUtils.verifyKeyNameWithSnapshotReservedWord(keyArgs.getKeyName());
`
is that so?
@errose28 , what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
