sodonnel commented on code in PR #11789:
URL: https://github.com/apache/ozone/pull/11789#discussion_r4391789906
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -233,7 +234,10 @@ public class RpcClient implements ClientProtocol {
private final boolean getLatestVersionLocation;
private final ByteBufferPool byteBufferPool;
private final BlockInputStreamFactory blockInputStreamFactory;
- private final OzoneManagerVersion omVersion;
+ private static final long OM_VERSION_REFRESH_INTERVAL =
TimeUnit.MINUTES.toMillis(10);
Review Comment:
Can we make this configurable? The standard pattern would be an
OzoneConfigKeys entry (e.g. ozone.client.om.version.refresh.interval) with a
10-minute default and ConfigTag.CLIENT. Also update the tests to pull from the
config and work correctly if someone changes the default at some point without
needing to change the tests later. I think the tests already do that as there
are no random times in them - they all just use the hard coded value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
