smengcl commented on code in PR #11591:
URL: https://github.com/apache/ozone/pull/11591#discussion_r4304165703
##########
.github/workflows/post-commit.yml:
##########
@@ -17,6 +17,24 @@ on:
pull_request:
types: [opened, ready_for_review, synchronize]
push:
+ paths-ignore:
+ # ignore files/dirs irrelevant for CI
+ - '.asf.yaml'
+ - '.devcontainer'
+ - '.editorconfig'
+ - '.gitattributes'
+ - '.gitignore'
+ - '.idea'
+ - '.run'
Review Comment:
I think a bare directory name only matches a file with that exact path, not
the files under it (the cheat sheet only shows `docs/*` and `docs/**` for
directories). So a push touching only `.run/*.run.xml` or
`.devcontainer/devcontainer.json` would still trigger the build. The test
commit did not cover these.
Should these be `.devcontainer/**` and `.run/**`? `.idea` is in
`.gitignore`, so it could probably be dropped.
##########
.github/workflows/post-commit.yml:
##########
@@ -17,6 +17,24 @@ on:
pull_request:
types: [opened, ready_for_review, synchronize]
push:
+ paths-ignore:
+ # ignore files/dirs irrelevant for CI
+ - '.asf.yaml'
+ - '.devcontainer'
+ - '.editorconfig'
+ - '.gitattributes'
+ - '.gitignore'
+ - '.idea'
+ - '.run'
+ - '**.md'
+ - '**.txt'
Review Comment:
These also match a few files that the build or tests depend on:
- `hadoop-hdds/rocks-native/src/CMakeLists.txt`
- `hadoop-ozone/dist/src/main/license/jar-report.txt`, which
`selective_ci_checks.sh` treats as needing a build (`dependency` check)
- resources loaded by code, like
`hadoop-ozone/recon/src/main/resources/chatbot/*.txt` and
`recon-tool-semantics.md`, and
`hadoop-ozone/recon/src/test/resources/prometheus-test-response.txt`
Maybe re-include them after these patterns:
```yaml
- '!**/CMakeLists.txt'
- '!**/src/main/resources/**'
- '!**/src/test/resources/**'
- '!hadoop-ozone/dist/src/main/license/jar-report.txt'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
