rich7420 commented on code in PR #11044:
URL: https://github.com/apache/ozone/pull/11044#discussion_r3835592900
##########
hadoop-ozone/cli-debug/src/main/java/org/apache/hadoop/ozone/debug/replicas/ReplicasVerify.java:
##########
@@ -346,13 +346,40 @@ void processKey(OzoneClient ozoneClient, String
volumeName, String bucketName, S
return;
}
+ KeyVerificationResult keyVerificationResult = verifyKey(keyInfo,
volumeName, bucketName, keyName);
+ if (keyVerificationResult.shouldRefreshKeyLocation()) {
+ OmKeyInfo refreshedKeyInfo = ozoneClient.getProxy().getKeyInfo(
Review Comment:
The retry path looks good. The same exposure remains on the initial
`getKeyInfo` in `processKey` (~L340): `checkBucket` iterates `listKeys()` with
no per-key catch, so a key deleted between listing and this fetch throws
`KEY_NOT_FOUND` and aborts the whole run (remaining keys unverified, and the
output is never written). Worth the same catch-and-continue there, or wrapping
the per-key body in `checkBucket`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
