rich7420 commented on code in PR #11044:
URL: https://github.com/apache/ozone/pull/11044#discussion_r3828233767
##########
hadoop-ozone/cli-debug/src/main/java/org/apache/hadoop/ozone/debug/replicas/ReplicasVerify.java:
##########
@@ -346,13 +346,40 @@ void processKey(OzoneClient ozoneClient, String
volumeName, String bucketName, S
return;
}
+ KeyVerificationResult keyVerificationResult = verifyKey(keyInfo,
volumeName, bucketName, keyName);
+ if (keyVerificationResult.shouldRefreshKeyLocation()) {
+ OmKeyInfo refreshedKeyInfo = ozoneClient.getProxy().getKeyInfo(
Review Comment:
This retry fetch isn't wrapped — if `getKeyInfo(..., true)` throws (key
deleted mid-run, OM error), `processKey` propagates and aborts the whole
verification run. The read path this mirrors catches/logs and continues instead
(`RpcClient` ~L2365). Suggest catching it here and marking the key incomplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
