yandrey321 commented on code in PR #9825:
URL: https://github.com/apache/ozone/pull/9825#discussion_r2853584656
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java:
##########
@@ -135,15 +132,32 @@ public OzoneManagerStateMachine(OzoneManagerRatisServer
ratisServer,
this.nettyMetrics = NettyMetrics.create();
}
+ @VisibleForTesting
+ OzoneManagerStateMachine(OzoneManager ozoneManager,
+ OzoneManagerDoubleBuffer doubleBuffer,
+ RequestHandler handler,
+ ExecutorService executorService,
+ NettyMetrics nettyMetrics) {
+ this.isTracingEnabled = false;
+ this.ozoneManager = ozoneManager;
+ this.threadPrefix = "";
+ this.ozoneManagerDoubleBuffer = doubleBuffer;
+ this.handler = handler;
+ this.executorService = executorService;
+ ThreadFactory installSnapshotThreadFactory = new ThreadFactoryBuilder()
+ .setNameFormat("TestInstallSnapshotThread").build();
+ this.installSnapshotExecutor =
+ HadoopExecutors.newSingleThreadExecutor(installSnapshotThreadFactory);
+ this.nettyMetrics = nettyMetrics;
+ }
+
/**
* Initializes the State Machine with the given server, group and storage.
*/
@Override
- public void initialize(RaftServer server, RaftGroupId id,
- RaftStorage raftStorage) throws IOException {
+ public void initialize(RaftServer server, RaftGroupId id, RaftStorage
raftStorage) throws IOException {
getLifeCycle().startAndTransition(() -> {
super.initialize(server, id, raftStorage);
- storage.init(raftStorage);
Review Comment:
why init() is removed here? its functional change, not just adding new tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
