fapifta opened a new pull request, #9825:
URL: https://github.com/apache/ozone/pull/9825
## What changes were proposed in this pull request?
Provide a one-liner summary of the changes in the PR **Title** field above.
It should be in the form of `HDDS-1234. Short summary of the change`.
Please describe your PR in detail:
This PR and its description was fully done by Claude-code based on my
direction and requests.
- Significantly expands unit test coverage for OzoneManagerStateMachine,
growing from ~5 tests to 30+
tests covering startTransaction, preAppendTransaction, applyTransaction,
runCommand, processResponse,
createErrorResponse, query, takeSnapshot, loadSnapshotInfoFromDB,
leader/configuration change
notifications, snapshot installation, and lifecycle methods
(pause/stop/close).
- Adds a @VisibleForTesting constructor that accepts mock-friendly
dependencies (OzoneManager,
OzoneManagerDoubleBuffer, RequestHandler, ExecutorService, NettyMetrics),
replacing the heavy setup that
required a real OmMetadataManagerImpl and Ratis server.
- Widens visibility of processResponse, runCommand, and
createErrorResponse from private to
package-private for direct unit testing.
- Removes the unused SimpleStateMachineStorage field and its
initialization in initialize().
- Adds a test in TestOzoneManagerRequestHandler verifying that audit log
messages include the correct
transaction index and command type when handleWriteRequestImpl encounters
an exception.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14717
## How was this patch tested?
New tests were running locally.
Generated-by: Claude - Opus 4.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
