adoroszlai commented on PR #8644: URL: https://github.com/apache/ozone/pull/8644#issuecomment-2986742457
On a related note: I don't think it's good practice to have two or more pull requests in parallel with similar code change handling different case (stream vs. non-stream write path). You inevitably get duplication in one or more areas: - review effort - your effort (e.g. to tweak the exception message in #8642 based on comment made here) - code - CI Depending on the size of the changes, please either: - create one PR at a time, wait for it to be merged, then your next PR starts in a better shape, OR - if the patches are small and changes are related, submit a single combined PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
