sumitagrawl commented on code in PR #8644:
URL: https://github.com/apache/ozone/pull/8644#discussion_r2154041320


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/StreamDataChannelBase.java:
##########
@@ -93,6 +94,14 @@ public final boolean isOpen() {
     return getChannel().isOpen();
   }
 
+  protected void assertSpaceAvailability() throws IOException {
+    if (containerData.getVolume().isVolumeFull()) {
+      throw new StorageContainerException("write failed for container " + 
containerData.getContainerID()
+          + " due to volume " + containerData.getVolume().getStorageID() + " 
out of space "
+          + containerData.getVolume().getCurrentUsage(), DISK_OUT_OF_SPACE);

Review Comment:
   @adoroszlai others are done, but unable to move to HddsVolume as log message 
needs `containerId` which is not present as part of HddsVolume. For log 
completeness, it should be done at outer layer, or need encapsulate exception 
again adding more details at outer layer. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to