smengcl commented on code in PR #8555:
URL: https://github.com/apache/ozone/pull/8555#discussion_r2138540568
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -764,6 +764,11 @@ public static String getSnapshotPath(OzoneConfiguration
conf,
OM_DB_NAME + snapshotInfo.getCheckpointDirName();
}
+ public static String getSnapshotLocalPropertyYamlPath(OzoneConfiguration
conf,
+ SnapshotInfo snapshotInfo) {
+ return getSnapshotPath(conf, snapshotInfo) + ".yaml";
Review Comment:
Personally I prefer the latter because it looks cleaner when I do `ls -l` on
the `checkpointState` dir, where each snapshot checkpoint would be accompanied
by a yaml file right below its listing item. In cases where we have to do
manual surgeries it would be easier to locate the yaml (harder to miss).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
