SaketaChalamchala commented on code in PR #8555:
URL: https://github.com/apache/ozone/pull/8555#discussion_r2138057361
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -764,6 +764,11 @@ public static String getSnapshotPath(OzoneConfiguration
conf,
OM_DB_NAME + snapshotInfo.getCheckpointDirName();
}
+ public static String getSnapshotLocalPropertyYamlPath(OzoneConfiguration
conf,
+ SnapshotInfo snapshotInfo) {
+ return getSnapshotPath(conf, snapshotInfo) + ".yaml";
Review Comment:
Shouldn't we be writing the yaml file to a separate metadata dir
`om.getMetadataManager().getStore().getSnapshotsParentDir() +
"/metadata/<snapshotID>.yaml"` which will be
`db.snapshots/checkpointState/metadata/<snapshotID>.yaml` instead of in the
snapshotPath `db.snapshots/checkpointState/om.db-<snapshotID>.yaml`?
That way it may be easier to transfer it in the checkpoint tarball during
bootstrap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
