smengcl commented on code in PR #8433:
URL: https://github.com/apache/ozone/pull/8433#discussion_r2087220218
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -892,6 +893,9 @@ message SnapshotInfo {
// note: shared sizes can be calculated from: referenced - exclusive
optional bool deepCleanedDeletedDir = 19;
optional bytes lastTransactionInfo = 20;
+ optional uint64 exclusiveDirSize = 21;
Review Comment:
Summary from offline discussion:
1. `exclusiveDirSize` is used exclusively by
`SnapshotDirectoryCleaningService` so as to eliminate race condition with
`KeyDeletingService`, which updates `exclusiveSize` at the same time and can
cause race condition. The name `exclusiveDirSize` is misleading from my point
of view and thus I suggest changing it.
3. The true `exclusiveSize` is now the combination of both as reflected in
`OzoneSnapshot`. It is unfortunate that we can't change the proto field names
without careful compatibility considerations.
4. `SnapshotDirectoryCleaningService` would be removed later according to
@swamirishi
5. Existing `SnapshotInfo` with incorrect `exclusiveSize` and
`exclusiveReplicatedSize` can be updated by reseting `deepCleanedDeletedDir`
flag then triggering the calculation again. For which we need a small tool for
that. cc @sumitagrawl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
