smengcl commented on code in PR #8433: URL: https://github.com/apache/ozone/pull/8433#discussion_r2087203681
########## hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto: ########## @@ -892,6 +893,9 @@ message SnapshotInfo { // note: shared sizes can be calculated from: referenced - exclusive optional bool deepCleanedDeletedDir = 19; optional bytes lastTransactionInfo = 20; + optional uint64 exclusiveDirSize = 21; + // snapshot exclusive size after replication + optional uint64 exclusiveDirReplicatedSize = 22; Review Comment: I'd suggest naming the variable as specific as possible since this is updated exclusively by `SnapshotDirectoryCleaningService`: ```suggestion optional uint64 exclusiveSizeDeltaFromSDCS = 21; // snapshot exclusive size after replication optional uint64 exclusiveReplicatedSizeDeltaFromSDCS = 22; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org