jojochuang commented on code in PR #8432:
URL: https://github.com/apache/ozone/pull/8432#discussion_r2085184720
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/AbstractKeyDeletingService.java:
##########
@@ -229,6 +231,10 @@ private int
submitPurgeKeysRequest(List<DeleteBlockGroupResult> results,
return deletedCount;
}
+ protected OzoneManagerProtocolProtos.OMResponse submitRequest(OMRequest
omRequest) throws ServiceException {
+ return OzoneManagerRatisUtils.submitRequest(ozoneManager, omRequest,
clientId, callId.incrementAndGet());
Review Comment:
and i think this API is easy to misuse. We need a little more javadoc for
the callId so caller is expected to ensure callId is unique for different
requests but remains the same for the same request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
