adoroszlai commented on code in PR #8432:
URL: https://github.com/apache/ozone/pull/8432#discussion_r2084871459
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/AbstractKeyDeletingService.java:
##########
@@ -613,6 +615,10 @@ public AtomicLong getRunCount() {
return runCount;
}
+ public AtomicLong getCallId() {
+ return callId;
+ }
Review Comment:
Instead of exposing `callId`, please create a `protected` method for
submitting request:
```java
protected OzoneManagerProtocolProtos.OMResponse submitRequest(OMRequest
omRequest) throws ServiceException {
return OzoneManagerRatisUtils.submitRequest(ozoneManager, omRequest,
clientId, callId.incrementAndGet());
}
```
and replace all calls of `OzoneManagerRatisUtils.submitRequest` in
`AbstractKeyDeletingService` and subclasses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
