sumitagrawl commented on code in PR #8388:
URL: https://github.com/apache/ozone/pull/8388#discussion_r2084241719
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -293,10 +292,9 @@ public class DatanodeConfiguration extends
ReconfigurableConfig {
" When the difference between volume capacity and used reaches
(free.space.percent of volume capacity)," +
" containers that reside on this volume will be closed and no new
containers" +
" would be allocated on this volume." +
- " Either of min.free.space or min.free.space.percent should be
configured, when both are set then" +
- " min.free.space will be used."
+ " Max of min.free.space or min.free.space.percent will be configured
when both are set."
Review Comment:
done
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/statemachine/TestDatanodeConfiguration.java:
##########
@@ -186,11 +193,11 @@ void rejectsInvalidMinFreeSpaceRatio() {
DatanodeConfiguration subject =
conf.getObject(DatanodeConfiguration.class);
- assertEquals(DatanodeConfiguration.MIN_FREE_SPACE_UNSET,
subject.getMinFreeSpaceRatio());
+ assertEquals(HDDS_DATANODE_VOLUME_MIN_FREE_SPACE_PERCENT_DEFAULT,
subject.getMinFreeSpaceRatio());
}
@Test
- void useMinFreeSpaceIfBothMinFreeSpacePropertiesSet() {
+ void useMaxAsPercentIfBothMinFreeSpacePropertiesSet() {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
