sumitagrawl commented on code in PR #8388: URL: https://github.com/apache/ozone/pull/8388#discussion_r2083766074
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java: ########## @@ -296,7 +297,7 @@ public class DatanodeConfiguration extends ReconfigurableConfig { " Either of min.free.space or min.free.space.percent should be configured, when both are set then" + " min.free.space will be used." ) - private float minFreeSpaceRatio = MIN_FREE_SPACE_UNSET; + private float minFreeSpaceRatio = HDDS_DATANODE_VOLUME_MIN_FREE_SPACE_PERCENT_DEFAULT; Review Comment: updated ########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java: ########## @@ -66,12 +66,13 @@ public class DatanodeConfiguration extends ReconfigurableConfig { // Ex: If volume has 1000GB and minFreeSpace is configured as 10GB, // In this case when availableSpace is 10GB or below, volume is assumed as full public static final String HDDS_DATANODE_VOLUME_MIN_FREE_SPACE = "hdds.datanode.volume.min.free.space"; - public static final String HDDS_DATANODE_VOLUME_MIN_FREE_SPACE_DEFAULT = "5GB"; + public static final String HDDS_DATANODE_VOLUME_MIN_FREE_SPACE_DEFAULT = "20GB"; // Minimum percent of space should be left on volume. // Ex: If volume has 1000GB and minFreeSpacePercent is configured as 2%, // In this case when availableSpace is 20GB(2% of 1000) or below, volume is assumed as full public static final String HDDS_DATANODE_VOLUME_MIN_FREE_SPACE_PERCENT = "hdds.datanode.volume.min.free.space.percent"; + public static final float HDDS_DATANODE_VOLUME_MIN_FREE_SPACE_PERCENT_DEFAULT = 0.001f; Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org