kerneltime commented on code in PR #8203:
URL: https://github.com/apache/ozone/pull/8203#discussion_r2070844226
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreCodecBufferIterator.java:
##########
@@ -18,13 +18,23 @@
package org.apache.hadoop.hdds.utils.db;
import java.io.IOException;
+import java.util.Deque;
+import java.util.HashSet;
import java.util.Optional;
-import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.Set;
+import java.util.concurrent.BlockingDeque;
+import java.util.concurrent.LinkedBlockingDeque;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.Function;
+import org.apache.commons.lang3.exception.UncheckedInterruptedException;
import org.apache.hadoop.hdds.utils.db.managed.ManagedRocksIterator;
import org.apache.ratis.util.Preconditions;
+import org.apache.ratis.util.ReferenceCountedObject;
/**
* Implement {@link RDBStoreAbstractIterator} using {@link CodecBuffer}.
+ * Any Key or Value returned will be only valid within the lifecycle of this
iterator.
*/
Review Comment:
```suggestion
/**
* An implementation of {@link RDBStoreAbstractIterator} that uses {@link
CodecBuffer}
* for efficient memory management when iterating over RocksDB entries.
* <p>
* This iterator employs a buffer pooling strategy to minimize memory
allocations
* during iteration. Key and value buffers are pre-allocated and reused
through a
* reference-counting mechanism, which significantly reduces GC pressure when
* processing large datasets.
* <p>
* Key features:
* <ul>
**/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
