sadanand48 commented on code in PR #8124:
URL: https://github.com/apache/ozone/pull/8124#discussion_r2048292214
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java:
##########
@@ -1436,19 +1436,26 @@ private CancelSnapshotDiffResponse cancelSnapshotDiff(
}
private ListSnapshotDiffJobResponse listSnapshotDiffJobs(
- ListSnapshotDiffJobRequest listSnapshotDiffJobRequest)
- throws IOException {
- List<SnapshotDiffJob> snapshotDiffJobs =
- impl.listSnapshotDiffJobs(
- listSnapshotDiffJobRequest.getVolumeName(),
- listSnapshotDiffJobRequest.getBucketName(),
- listSnapshotDiffJobRequest.getJobStatus(),
- listSnapshotDiffJobRequest.getListAll());
- ListSnapshotDiffJobResponse.Builder builder =
- ListSnapshotDiffJobResponse.newBuilder();
- for (SnapshotDiffJob diffJob : snapshotDiffJobs) {
+ ListSnapshotDiffJobRequest listSnapshotDiffJobRequest
+ ) throws IOException {
+ org.apache.hadoop.ozone.snapshot.ListSnapshotDiffJobResponse response =
impl.listSnapshotDiffJobs(
+ listSnapshotDiffJobRequest.getVolumeName(),
+ listSnapshotDiffJobRequest.getBucketName(),
+ listSnapshotDiffJobRequest.getJobStatus(),
+ listSnapshotDiffJobRequest.getListAll(),
+ listSnapshotDiffJobRequest.getPrevSnapshotDiffJob(),
+ listSnapshotDiffJobRequest.getMaxListResult());
Review Comment:
Ok yes thanks, I see this handled in the method and it won't be 0 then.
> if (maxListResult <= 0 || maxListResult > maxPageSize) {
> maxListResult = maxPageSize;
> }
Sounds good, thanks for explaining.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
