hemantk-12 commented on code in PR #8124:
URL: https://github.com/apache/ozone/pull/8124#discussion_r2048286026
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java:
##########
@@ -1436,19 +1436,26 @@ private CancelSnapshotDiffResponse cancelSnapshotDiff(
}
private ListSnapshotDiffJobResponse listSnapshotDiffJobs(
- ListSnapshotDiffJobRequest listSnapshotDiffJobRequest)
- throws IOException {
- List<SnapshotDiffJob> snapshotDiffJobs =
- impl.listSnapshotDiffJobs(
- listSnapshotDiffJobRequest.getVolumeName(),
- listSnapshotDiffJobRequest.getBucketName(),
- listSnapshotDiffJobRequest.getJobStatus(),
- listSnapshotDiffJobRequest.getListAll());
- ListSnapshotDiffJobResponse.Builder builder =
- ListSnapshotDiffJobResponse.newBuilder();
- for (SnapshotDiffJob diffJob : snapshotDiffJobs) {
+ ListSnapshotDiffJobRequest listSnapshotDiffJobRequest
+ ) throws IOException {
+ org.apache.hadoop.ozone.snapshot.ListSnapshotDiffJobResponse response =
impl.listSnapshotDiffJobs(
+ listSnapshotDiffJobRequest.getVolumeName(),
+ listSnapshotDiffJobRequest.getBucketName(),
+ listSnapshotDiffJobRequest.getJobStatus(),
+ listSnapshotDiffJobRequest.getListAll(),
+ listSnapshotDiffJobRequest.getPrevSnapshotDiffJob(),
+ listSnapshotDiffJobRequest.getMaxListResult());
Review Comment:
I made the change to explicitly return `maxPageSize` entries if
`MaxListResult` is not passed.
https://github.com/apache/ozone/pull/8124/commits/20b60bad97b45ddef9f0f1422ec9494aa4681923
/
https://github.com/apache/ozone/pull/8124/files#diff-4e1ce03634e167877ec3c4d055a744b753d087ef7d9a3ed842f9936ef519aa71R1443-R1444
Please take a look again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
