szetszwo commented on code in PR #8059:
URL: https://github.com/apache/ozone/pull/8059#discussion_r1998394460
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -714,6 +716,10 @@ private OzoneManager(OzoneConfiguration conf,
StartupOption startupOption)
if (isOmGrpcServerEnabled) {
omS3gGrpcServer = getOmS3gGrpcServer(configuration);
}
+
+ // init om gateway for request
Review Comment:
gateway -> execution flow
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisRequest.java:
##########
@@ -109,6 +110,8 @@ public void testUnknownRequestHandling()
omMetadataManager = new OmMetadataManagerImpl(ozoneConfiguration,
ozoneManager);
when(ozoneManager.getMetadataManager()).thenReturn(omMetadataManager);
+ OMExecutionFlow omGateway = new OMExecutionFlow(ozoneManager);
Review Comment:
gateway -> execution flow
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java:
##########
@@ -515,6 +515,22 @@ public static GrpcTlsConfig
createServerTlsConfig(SecurityConfig conf,
public static OzoneManagerProtocolProtos.OMResponse submitRequest(
OzoneManager om, OMRequest omRequest, ClientId clientId, long callId)
throws ServiceException {
- return om.getOmRatisServer().submitRequest(omRequest, clientId, callId);
+ return om.getOmExecutionFlow().submitInternal(omRequest, clientId, callId);
Review Comment:
It is not clear why we need om -> executionFlow -> om in the changes here .
Let's change this line and add `submitInternal` later when they are needed.
We can see if there is a better way to arrange the code at that time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
