sumitagrawl commented on code in PR #8059:
URL: https://github.com/apache/ozone/pull/8059#discussion_r1996959800
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java:
##########
@@ -515,6 +515,22 @@ public static GrpcTlsConfig
createServerTlsConfig(SecurityConfig conf,
public static OzoneManagerProtocolProtos.OMResponse submitRequest(
OzoneManager om, OMRequest omRequest, ClientId clientId, long callId)
throws ServiceException {
- return om.getOmRatisServer().submitRequest(omRequest, clientId, callId);
+ return om.getOmGateway().submitInternal(omRequest, clientId, callId);
Review Comment:
1. External flow: call is submitted via
[OzoneManagerProtocolServerSideTranslatorPB.java](https://github.com/apache/ozone/pull/8059/files/8a27f93dc228e99bd8f19d4f9c97dc6c6dd9d2c1#diff-5442b6ab8b3bd0c366a4b992e683efe2d4ef0fb9826b73cc560e1915baa12d7a)
as om.getOmGateway().submit(request)
2. Internal flow: call is submitted via
[OzoneManagerRatisUtils.java](https://github.com/apache/ozone/pull/8059/files/8a27f93dc228e99bd8f19d4f9c97dc6c6dd9d2c1#diff-0cfd85e1e649ee3e5fd468cff0a5cac05d1743f331af4a0f445d83fc8a77c5af)
as om.getOmGateway().submitInternal(request, ...) as we have variation like
pre-execute is not required.
OM keeps track of OmRatisServer as resource, instead of keeping member
variable with ozoneManager.getOmRatisServer() value, I think using getter is
better.
Please share your opinion over this if any thing to change...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
