szetszwo commented on code in PR #8083:
URL: https://github.com/apache/ozone/pull/8083#discussion_r1996089558
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/states/ContainerAttribute.java:
##########
@@ -60,37 +61,30 @@
* @param <T> Attribute type
*/
public class ContainerAttribute<T extends Enum<T>> {
- private static final Logger LOG =
- LoggerFactory.getLogger(ContainerAttribute.class);
-
private final Class<T> attributeClass;
- private final ImmutableMap<T, NavigableSet<ContainerID>> attributeMap;
+ private final ImmutableMap<T, NavigableMap<ContainerID, ContainerInfo>>
attributeMap;
/**
* Create an empty Container Attribute map.
*/
public ContainerAttribute(Class<T> attributeClass) {
this.attributeClass = attributeClass;
- final EnumMap<T, NavigableSet<ContainerID>> map = new
EnumMap<>(attributeClass);
+ final EnumMap<T, NavigableMap<ContainerID, ContainerInfo>> map = new
EnumMap<>(attributeClass);
for (T t : attributeClass.getEnumConstants()) {
- map.put(t, new TreeSet<>());
+ map.put(t, new TreeMap<>());
}
this.attributeMap = Maps.immutableEnumMap(map);
}
/**
- * Insert the value in the Attribute map, keep the original value if it
exists
- * already.
- *
- * @param key - The key to the set where the ContainerID should exist.
- * @param value - Actual Container ID.
- * @return true if the value is added;
- * otherwise, the value already exists, return false.
+ * Add the given non-existing {@link ContainerInfo} to this attribute.
+ * @throws IllegalStateException if it already exists.
*/
- public boolean insert(T key, ContainerID value) {
- Objects.requireNonNull(value, "value == null");
- return get(key).add(value);
+ public void addNonExisting(T key, ContainerInfo info) {
+ Objects.requireNonNull(info, "value == null");
+ final ContainerInfo previous = get(key).put(info.containerID(), info);
Review Comment:
This method is for adding non-existing elements. So, `put` is okay since
the next line will throw IllegalStateException in case of overwriting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
