szetszwo commented on code in PR #8083:
URL: https://github.com/apache/ozone/pull/8083#discussion_r1996111393
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/states/TestContainerAttribute.java:
##########
@@ -43,32 +45,35 @@ static <T extends Enum<T>> boolean
hasContainerID(ContainerAttribute<T> attribut
}
static <T extends Enum<T>> boolean hasContainerID(ContainerAttribute<T>
attribute, T key, ContainerID id) {
- final NavigableSet<ContainerID> set = attribute.get(key);
- return set != null && set.contains(id);
+ final NavigableMap<ContainerID, ContainerInfo> map = attribute.get(key);
+ return map != null && map.containsKey(id);
}
@Test
- public void testInsert() {
+ public void testAddNonExisting() {
ContainerAttribute<Key> containerAttribute = new
ContainerAttribute<>(Key.class);
- ContainerID id = ContainerID.valueOf(42);
- containerAttribute.insert(key1, id);
+ ContainerInfo info = new
ContainerInfo.Builder().setContainerID(42).build();
+ ContainerID id = info.containerID();
+ containerAttribute.addNonExisting(key1, info);
assertEquals(1, containerAttribute.getCollection(key1).size());
- assertThat(containerAttribute.getCollection(key1)).contains(id);
-
- // Insert again and verify that the new ContainerId is inserted.
- ContainerID newId =
- ContainerID.valueOf(42);
- containerAttribute.insert(key1, newId);
- assertEquals(1, containerAttribute.getCollection(key1).size());
- assertThat(containerAttribute.getCollection(key1)).contains(newId);
+ assertThat(containerAttribute.get(key1)).containsKey(id);
+
+ // Adding it again should fail.
+ try {
+ containerAttribute.addNonExisting(key1, info);
+ fail();
+ } catch (IllegalStateException e) {
+ e.printStackTrace(System.out);
+ }
Review Comment:
I missed this comment previously. Let me update the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
