ptlrs commented on code in PR #7934:
URL: https://github.com/apache/ozone/pull/7934#discussion_r1988347434
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java:
##########
@@ -552,13 +553,17 @@ public ContainerType getContainerType() {
}
@Override
- public void update(
- Map<String, String> metadata, boolean forceUpdate)
+ public void update(Map<String, String> metadata, boolean forceUpdate)
throws StorageContainerException {
+ update(metadata, forceUpdate, containerData.getMetadataPath());
+ }
+ @Override
+ public void update(Map<String, String> metadata, boolean forceUpdate, String
containerMetadataPath)
+ throws StorageContainerException {
// TODO: Now, when writing the updated data to .container file, we are
- // holding lock and writing data to disk. We can have async implementation
- // to flush the update container data to disk.
+ // holding lock and writing data to disk. We can have async implementation
+ // to flush the update container data to disk.
Review Comment:
Extra indentation required for the comments to be interpreted as part of the
TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
